Add default push rule to ignore reactions#976
Merged
Conversation
This adds a default push rule to ignore reactions as proposed in [MSC2153](matrix-org/matrix-spec-proposals#2153). By adding it here in the client directly, we can try out the idea early even if it hasn't appeared in the user's HS yet. Part of element-hq/element-web#10208
3 tasks
turt2live
approved these changes
Jul 4, 2019
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm from a code perspective. Does this need a react-sdk component similar to the tombstone (or are we okay with it being one of the many hidden options)?
I would want a checkmark from Dave on either this or the MSC before calling this safe to merge though.
Collaborator
Author
I think it's okay for it to be hidden for the moment. If we later find out that there in fact are many people who want reactions to notify, we can expose an option for that. |
Collaborator
Author
|
Dave has approved the MSC, so I'll proceed with landing this. |
jryans
added a commit
to matrix-org/synapse
that referenced
this pull request
Jul 5, 2019
This adds a default push rule following the proposal in [MSC2153](matrix-org/matrix-spec-proposals#2153). See also element-hq/element-web#10208 See also matrix-org/matrix-js-sdk#976
jryans
added a commit
to matrix-org/synapse
that referenced
this pull request
Jul 5, 2019
This adds a default push rule following the proposal in [MSC2153](matrix-org/matrix-spec-proposals#2153). See also element-hq/element-web#10208 See also matrix-org/matrix-js-sdk#976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a default push rule to ignore reactions as proposed in
MSC2153. By adding it here
in the client directly, we can try out the idea early even if it hasn't appeared
in the user's HS yet.
Part of element-hq/element-web#10208